Re: [PATCH 2/2] kern: fix the error handling in exec_load

[Samuel Thibault]

Justus Winter, le Mon 04 Nov 2013 19:18:35 +0100, a écrit :
> Found using the Clang Static Analyzer.
> 
> * kern/elf-load.c (exec_load): Properly propagate errors.

ACK

> ---
>  kern/elf-load.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kern/elf-load.c b/kern/elf-load.c
> index 1d103d3..441276e 100644
> --- a/kern/elf-load.c
> +++ b/kern/elf-load.c
> @@ -80,6 +80,8 @@ int exec_load(exec_read_func_t *read, exec_read_exec_func_t 
> *read_exec,
>                       result = (*read_exec)(handle,
>                                             ph->p_offset, ph->p_filesz,
>                                             ph->p_vaddr, ph->p_memsz, type);
> +                     if (result)
> +                             return result;
>               }
>       }
>  
> -- 
> 1.7.10.4
> 
> 

-- 
Samuel
* B kicks DW (non mais franchement)
* DW was kicked
 -+- #ens-mim - comment ça hopeless ? -+-