Re: [PATCH 14/14] mach-defpager: remove unused variables

[Samuel Thibault]

Justus Winter, le Fri 08 Nov 2013 21:24:22 +0100, a écrit :
> Found using the Clang Static Analyzer.
> 
> * mach-defpager/default_pager.c (seqnos_memory_object_terminate):
>   Remove unused variables request_refs and name_refs.

Ack

> ---
>  mach-defpager/default_pager.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c
> index 674f4c3..e865397 100644
> --- a/mach-defpager/default_pager.c
> +++ b/mach-defpager/default_pager.c
> @@ -2510,7 +2510,6 @@ seqnos_memory_object_terminate(pager, seqno, 
> pager_request, pager_name)
>       mach_port_t     pager_name;
>  {
>       register default_pager_t        ds;
> -     mach_port_urefs_t               request_refs, name_refs;
>       kern_return_t                   kr;
>       static char                     here[] = "%sterminate";
>  
> @@ -2549,11 +2548,9 @@ ddprintf ("seqnos_memory_object_terminate <%p>: 
> pager_port_lock: <%p>[s:%d,r:%d,
>       if (ds->external)
>               pager_request = ds->pager_request;
>       ds->pager_request = MACH_PORT_NULL;
> -     request_refs = ds->request_refs;
>       ds->request_refs = 0;
>       assert(ds->pager_name == pager_name);
>       ds->pager_name = MACH_PORT_NULL;
> -     name_refs = ds->name_refs;
>       ds->name_refs = 0;
>  ddprintf ("seqnos_memory_object_terminate <%p>: pager_port_unlock: 
> <%p>[s:%d,r:%d,w:%d,l:%d]\n",
>       &kr, ds, ds->seqno, ds->readers, ds->writers, ds->lock.held);
> -- 
> 1.7.10.4
> 
> 

-- 
Samuel
`When you say "I wrote a program that crashed Windows", people just stare at
you blankly and say "Hey, I got those with the system, *for free*".'
(By Linus Torvalds)