[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap
From: |
Marin Ramesa |
Subject: |
[PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap |
Date: |
Sun, 10 Nov 2013 22:50:21 +0100 |
Value of node is never read. Simplify the node swap to one assignment
and remove the temporary variable.
* kern/rbtree.c (rbtree_insert_rebalance): Simplify node swap.
---
kern/rbtree.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kern/rbtree.c b/kern/rbtree.c
index 0f5eb9a..d90a8bc 100644
--- a/kern/rbtree.c
+++ b/kern/rbtree.c
@@ -147,7 +147,7 @@ static void rbtree_rotate(struct rbtree *tree, struct
rbtree_node *node,
void rbtree_insert_rebalance(struct rbtree *tree, struct rbtree_node *parent,
int index, struct rbtree_node *node)
{
- struct rbtree_node *grand_parent, *uncle, *tmp;
+ struct rbtree_node *grand_parent, *uncle;
int left, right;
assert(rbtree_check_alignment(parent));
@@ -196,9 +196,7 @@ void rbtree_insert_rebalance(struct rbtree *tree, struct
rbtree_node *parent,
*/
if (parent->children[right] == node) {
rbtree_rotate(tree, parent, left);
- tmp = node;
- node = parent;
- parent = tmp;
+ parent = node;
}
/*
--
1.8.1.4
[PATCH 3/5] kern: eliminate unused assignment, Marin Ramesa, 2013/11/10
[PATCH 4/5] vm: remove duplicate assignment, Marin Ramesa, 2013/11/10