[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap
|
From: |
Richard Braun |
|
Subject: |
Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap |
|
Date: |
Tue, 12 Nov 2013 11:56:05 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Nov 10, 2013 at 11:00:26PM +0100, Samuel Thibault wrote:
> Marin Ramesa, le Sun 10 Nov 2013 22:50:21 +0100, a écrit :
> > Value of node is never read. Simplify the node swap to one assignment
> > and remove the temporary variable.
> >
> > * kern/rbtree.c (rbtree_insert_rebalance): Simplify node swap.
>
> I'd rather keep it as such, as an expression of the rbtree rotation.
It's not a rotation, merely a variable swap, I would personally simplify
it too. FYI, Justus find it too with Clang if I'm right.
--
Richard Braun
[PATCH 3/5] kern: eliminate unused assignment, Marin Ramesa, 2013/11/10
[PATCH 4/5] vm: remove duplicate assignment, Marin Ramesa, 2013/11/10
[PATCH 5/5] vm: remove unused assignment, Marin Ramesa, 2013/11/10