[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] cleanup of #includes
|
From: |
Svante Signell |
|
Subject: |
Re: [RFC] cleanup of #includes |
|
Date: |
Thu, 14 Nov 2013 13:56:30 +0100 |
On Thu, 2013-11-14 at 12:41 +0100, Justus Winter wrote:
> Hi :)
>
> As an example of a patch generated here is a patch that fixes the
> includes in libihash/ihash.c.
>
> 1. Do you consider the comment describing which symbols are pulled
> from the header as noise or worthwile information?
Very useful!
> 2. Do you consider it too noisy to include mach-shortcuts.h instead of
> mach.h for stuff like mach_port_allocate?
No, otherwise you need to check which header files are included by
mach.h, to find the declaration of it in mach/mach_port.h.
- [RFC] cleanup of #includes, Justus Winter, 2013/11/14
- [PATCH] libihash: cleanup the #includes, Justus Winter, 2013/11/14
- Re: [RFC] cleanup of #includes,
Svante Signell <=
- Re: [RFC] cleanup of #includes, Neal H. Walfield, 2013/11/14
- Re: [RFC] cleanup of #includes, Svante Signell, 2013/11/14
- Re: [RFC] cleanup of #includes, Neal H. Walfield, 2013/11/14
- Re: [RFC] cleanup of #includes, Samuel Thibault, 2013/11/14
- [PATCH] Clean up the included header files, Justus Winter, 2013/11/15
- Re: [PATCH] Clean up the included header files, Samuel Thibault, 2013/11/16
Re: [RFC] cleanup of #includes, Richard Braun, 2013/11/14