Re: [PATCH 3/6] ext2fs: fix error handling

[Samuel Thibault]

Justus Winter, le Sat 16 Nov 2013 10:58:16 +0100, a écrit :
> Found using the Clang Static Analyzer.
> 
> * ext2fs/dir.c (diskfs_lookup_hard): Fix error handling.

Ack.

> ---
>  ext2fs/dir.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ext2fs/dir.c b/ext2fs/dir.c
> index c075246..a7eeaaa 100644
> --- a/ext2fs/dir.c
> +++ b/ext2fs/dir.c
> @@ -195,6 +195,8 @@ diskfs_lookup_hard (struct node *dp, const char *name, 
> enum lookup_type type,
>    err = vm_map (mach_task_self (),
>               &buf, buflen, 0, 1, memobj, 0, 0, prot, prot, 0);
>    mach_port_deallocate (mach_task_self (), memobj);
> +  if (err)
> +    return err;
>  
>    inum = 0;
>  
> -- 
> 1.7.10.4
> 

-- 
Samuel
<y> ça gaze ?
<l> prout
 -+- #ens-mim - ouvrez les fenêtres ! -+-