[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] i386/i386/db_interface.c: fix passing from incompatibl
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 01/11] i386/i386/db_interface.c: fix passing from incompatible pointer type |
|
Date: |
Wed, 20 Nov 2013 21:59:09 +0100 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Wed 20 Nov 2013 20:42:45 +0100, a écrit :
> * i386/i386/db_interface.c (db_user_to_kernel_address): Cast argument 3 to
> (unsigned int *).
db_user_to_kernel_address should rather be made to take a vm_offset_t*,
and caller use that, instead of unsigned int, for their variables. The
very good reason for this is that it's supposed to be an address. On
64bit systems, unsigned int is not big enough...
Samuel
- [PATCH 06/11] i386/i386/db_interface.c: comment function and the calls, (continued)
- [PATCH 06/11] i386/i386/db_interface.c: comment function and the calls, Marin Ramesa, 2013/11/20
- [PATCH 07/11] i386/i386/db_trace.c: cast to (int *), Marin Ramesa, 2013/11/20
- [PATCH 09/11] i386/i386/db_trace.c: don't cast to db_addr_t, Marin Ramesa, 2013/11/20
- [PATCH 08/11] i386/i386/db_trace.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- [PATCH 10/11] i386/i386/db_trace.c: return reg value, Marin Ramesa, 2013/11/20
- [PATCH 11/11] i386/i386/trap.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- Re: [PATCH 01/11] i386/i386/db_interface.c: fix passing from incompatible pointer type,
Samuel Thibault <=