[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] libps: fix the length computation in fprint_frac_value
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 03/12] libps: fix the length computation in fprint_frac_value |
Date: |
Wed, 20 Nov 2013 23:48:55 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 20 Nov 2013 14:37:56 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * libps/spec.c (fprint_frac_value): Fix computation of value_len.
Ack.
> ---
> libps/spec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libps/spec.c b/libps/spec.c
> index b34a234..146aba5 100644
> --- a/libps/spec.c
> +++ b/libps/spec.c
> @@ -416,7 +416,7 @@ sprint_frac_value (char *buf,
>
> if (value >= 1000) /* the integer part */
> value_len = 4; /* values 1000-1023 */
> - if (value >= 100)
> + else if (value >= 100)
> value_len = 3;
> else if (value >= 10)
> value_len = 2;
> --
> 1.7.10.4
>
--
Samuel
«Tiens, quand j'aurai un peu de temps et une partition libre, je crois
que je vais essayer de remplacer mes scripts de démarrage par des
programmes Windows lancés via Wine et binfmt_misc :-)»
-+- AGV in Guide du linuxien pervers - "J'sais pas quoi faire... (air connu)"
- [PATCH 01/12] init: remove unused function run_for_real, Justus Winter, 2013/11/20
- [PATCH 02/12] utils: fix dead initialization, Justus Winter, 2013/11/20
- [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard, Justus Winter, 2013/11/20
- [PATCH 04/12] libnetfs: fix a dead store, Justus Winter, 2013/11/20
- [PATCH 03/12] libps: fix the length computation in fprint_frac_value, Justus Winter, 2013/11/20
- Re: [PATCH 03/12] libps: fix the length computation in fprint_frac_value,
Samuel Thibault <=
- [PATCH 06/12] fatfs: fix error handling in diskfs_get_directs, Justus Winter, 2013/11/20
- [PATCH 07/12] ftpfs: fix error handling in refresh_dir, Justus Winter, 2013/11/20
- [PATCH 12/12] libshouldbeinlibc: fix error handling in maptime_map, Justus Winter, 2013/11/20
- [PATCH 09/12] usermux: actually use the computed flags value in netfs_attempt_utimes, Justus Winter, 2013/11/20
- [PATCH 08/12] nfsd: fix error handling in op_remove, Justus Winter, 2013/11/20