Re: [PATCH 09/12] usermux: actually use the computed flags value in netfs_attempt_utimes

[Samuel Thibault]

Justus Winter, le Wed 20 Nov 2013 14:38:02 +0100, a écrit :
> If either atime or mtime is NULL, the respective time should be set to
> the current time.
> 
> Found using the Clang Static Analyzer.
> 
> * usermux/node.c (netfs_attempt_utimes): Use flags in call to
>   fshelp_touch.

Ack.

> ---
>  usermux/node.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usermux/node.c b/usermux/node.c
> index 324b85b..2341714 100644
> --- a/usermux/node.c
> +++ b/usermux/node.c
> @@ -90,7 +90,7 @@ netfs_attempt_utimes (struct iouser *cred, struct node 
> *node,
>        else
>       flags |= TOUCH_ATIME;
>  
> -      fshelp_touch (&node->nn_stat, TOUCH_CTIME, usermux_maptime);
> +      fshelp_touch (&node->nn_stat, flags, usermux_maptime);
>      }
>    return err;
>  }
> -- 
> 1.7.10.4
> 

-- 
Samuel
"I once witnessed a long-winded, month-long flamewar over the use of
mice vs. trackballs...It was very silly."
(By Matt Welsh)