bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/19] Fix call of function with qualified void return type


From: Guillem Jover
Subject: Re: [PATCH 03/19] Fix call of function with qualified void return type
Date: Thu, 21 Nov 2013 00:28:17 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, 2013-11-20 at 21:33:54 +0100, Marin Ramesa wrote:
> On 20.11.2013 21:18:14, Guillem Jover wrote:
> > > diff --git a/i386/i386/setjmp.h b/i386/i386/setjmp.h
> > > index 667eecf..08626e3 100644
> > > --- a/i386/i386/setjmp.h
> > > +++ b/i386/i386/setjmp.h
> > > @@ -36,7 +36,7 @@ typedef struct jmp_buf {
> > >  extern int _setjmp(jmp_buf_t*);
> > >  
> > >  #ifdef __GNUC__
> > > -extern __volatile__ void _longjmp(jmp_buf_t*, int);
> > > +extern /*__volatile__*/ void _longjmp(jmp_buf_t*, int);
> > >  #endif
> > >  
> > >  #endif   /* _I386_SETJMP_H_ */
> > 
> > Why not just remove it?
> 
> Yes. It might be better to remove it. _longjmp is called only once.

Just to be clear, I meant removing __volatile__ (instead of commenting
it out), not removing the declaration.

Thanks,
Guillem



reply via email to

[Prev in Thread] Current Thread [Next in Thread]