[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration wi
From: |
Ivan Shmakov |
Subject: |
Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition |
Date: |
Fri, 29 Nov 2013 22:52:00 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
>>>>> Marin Ramesa <mpr@hi.t-com.hr> writes:
> * i386/i386/ldt.c (syscall): Remove forward declaration.
> (syscall): New variable.
[…]
> #include "ldt.h"
> -extern int syscall();
> -
> #ifdef MACH_PV_DESCRIPTORS
> /* It is actually defined in xen_boothdr.S */
> extern
> @@ -60,6 +58,7 @@ ldt_init()
> #endif /* MACH_PV_DESCRIPTORS */
> /* Initialize the LDT descriptors. */
> + int syscall;
> fill_ldt_gate(USER_SCALL,
> (vm_offset_t)&syscall, KERNEL_CS,
> ACC_PL_U|ACC_CALL_GATE, 0);
Correct me if I’m wrong, but doesn’t it replace a pointer to an
global (external) syscall () function with a pointer to a local
variable? I don’t seem to understand how the logic is preserved
in this change.
--
FSF associate member #7257
- [PATCH 10/68] ddb/db_command.c: remove forward declaration, (continued)
- [PATCH 10/68] ddb/db_command.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 11/68] ddb/db_command.c: remove useless forward declaration without definition, Marin Ramesa, 2013/11/29
- [PATCH 12/68] ddb/db_trap.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 13/68] ddb/db_variables.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 14/68] device/device_init.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 15/68] i386/i386/db_trace.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 16/68] i386/i386/fpu.c, trap.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 17/68] i386/i386/fpu.c: remove (#if 1), Marin Ramesa, 2013/11/29
- [PATCH 18/68] i386/i386/io_perm.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition, Marin Ramesa, 2013/11/29
- Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition,
Ivan Shmakov <=
[PATCH 21/68] kern: new header file exception.h, Marin Ramesa, 2013/11/29
[PATCH 20/68] i386/i386/pcb.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 22/68] kern/exception.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 23/68] i386/i386at/autoconf.c, com.c, lpr.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 25/68] i386/i386at/kd.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 24/68] i386/i386at/conf.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 26/68] i386/i386at/kd_event.c: remove forward declarations, Marin Ramesa, 2013/11/29