[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration wi
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition |
|
Date: |
Sat, 30 Nov 2013 00:22:53 +0100 |
On 29.11.2013 23:52:00, Ivan Shmakov wrote:
> Correct me if I’m wrong, but doesn’t it replace a pointer to
> an global (external) syscall () function with a pointer to a
> local variable? I don’t seem to understand how the logic is
> preserved in this change.
The function syscall() doesn't have a definition. so the extern
declaration is only a reserved address. It might as well be a local
variable. But I don't understand that code: why does the function
fill_ldt_gate() take a random address as an argument?
- [PATCH 11/68] ddb/db_command.c: remove useless forward declaration without definition, (continued)
- [PATCH 11/68] ddb/db_command.c: remove useless forward declaration without definition, Marin Ramesa, 2013/11/29
- [PATCH 12/68] ddb/db_trap.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 13/68] ddb/db_variables.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 14/68] device/device_init.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 15/68] i386/i386/db_trace.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 16/68] i386/i386/fpu.c, trap.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 17/68] i386/i386/fpu.c: remove (#if 1), Marin Ramesa, 2013/11/29
- [PATCH 18/68] i386/i386/io_perm.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition, Marin Ramesa, 2013/11/29
[PATCH 21/68] kern: new header file exception.h, Marin Ramesa, 2013/11/29
[PATCH 20/68] i386/i386/pcb.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 22/68] kern/exception.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 23/68] i386/i386at/autoconf.c, com.c, lpr.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 25/68] i386/i386at/kd.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 24/68] i386/i386at/conf.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 26/68] i386/i386at/kd_event.c: remove forward declarations, Marin Ramesa, 2013/11/29
[PATCH 27/68] i386/i386at/kd_mouse.c: remove forward declarations, Marin Ramesa, 2013/11/29