bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration wi


From: Samuel Thibault
Subject: Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition
Date: Sat, 30 Nov 2013 00:27:23 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Sat 30 Nov 2013 00:22:53 +0100, a écrit :
> On 29.11.2013 23:52:00, Ivan Shmakov wrote: 
> >     Correct me if I’m wrong, but doesn’t it replace a pointer to
> > an global (external) syscall () function with a pointer to a
> > local variable?  I don’t seem to understand how the logic is
> > preserved in this change.
> 
> The function syscall() doesn't have a definition. so the extern 
> declaration is only a reserved address. It might as well be a local 
> variable. But I don't understand that code: why does the function 
> fill_ldt_gate() take a random address as an argument?

It's not a random address:

./i386/i386/locore.S:ENTRY(syscall)

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]