[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration |
|
Date: |
Sat, 30 Nov 2013 00:32:22 +0100 |
On 29.11.2013 23:46:57, Ivan Shmakov wrote:
> Shouldn’t it be declared as ‘extern’ just as well? (And the
> argument names are unnecessary, BTW.) Also, it may make sense
> to “pair” it with thread_depress_timeout (), like:
It's used only locally, so I figured extern is not needed. The original
forward declaration didn't have an extern. But you're right, it should
be extern for consistency.
- Re: [PATCH 31/68] ipc/ipc_kmsg.c: remove forward declarations, (continued)
- [PATCH 33/68] ipc/mach_msg.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 34/68] kern/bootstrap.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 35/68] kern/debug.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 36/68] kern/ipc_mig.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 37/68] kern/processor.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 39/68] kern/startup.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 38/68] kern/sched_prim.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 40/68] kern/syscall_subr.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 41/68] kern/syscall_sw.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 42/68] kern/task.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 43/68] kern/thread.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 44/68] kern: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 45/68] ipc/ipc_kmsg.h: update comment, Marin Ramesa, 2013/11/29
- [PATCH 46/68] kern/ipc_kobject.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 47/68] vm/vm_fault.c: remove forward declaration, Marin Ramesa, 2013/11/29
- [PATCH 48/68] vm/vm_kern.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 50/68] vm/vm_pageout.c: remove forward declarations, Marin Ramesa, 2013/11/29
- [PATCH 49/68] vm/vm_map.c: remove forward declarations, Marin Ramesa, 2013/11/29