Re: [PATCH 29/68] i386/i386at/pic_isa.c: remove forward declaration

[Samuel Thibault]

Marin Ramesa, le Fri 29 Nov 2013 22:53:54 +0100, a écrit :
> --- a/kern/mach_clock.h
> +++ b/kern/mach_clock.h
> @@ -29,7 +29,7 @@
>  #include <mach/time_value.h>
>  #include <kern/host.h>
>  #include <kern/queue.h>
> -
> +#include <machine/thread.h>
>  
>  /* Timers in kernel.  */
>  extern unsigned long elapsed_ticks;  /* number of ticks elapsed since bootup 
> */
> @@ -107,4 +107,11 @@ extern boolean_t untimeout(timer_func_t *fcn, void 
> *param);
>  extern int timeopen(void);
>  extern int timeclose(void);
>  
> +void hardclock(
> +       int                           iunit,
> +     int                             old_ipl,
> +     int                             irq,
> +     char *                          ret_addr,
> +     struct i386_interrupt_state     *regs);
> +

Err, why in mach_clock.h while it's defined in i386/i386/hardclock.c?
"i386" appearing in a generic directory is not a good sign, either :)

Samuel