[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/18] Fix initialization from incompatible pointer type
|
From: |
Marin Ramesa |
|
Subject: |
Re: [PATCH 14/18] Fix initialization from incompatible pointer type |
|
Date: |
Sat, 07 Dec 2013 14:10:02 +0100 |
On 06.12.2013 16:29:56, Marin Ramesa wrote:
> This patch has one questionable addition, that is the cast from
> io_req_t to a pointer to uio struct in the function kdread().
> [...]
> - return((*linesw[kd_tty.t_line].l_read)(tp, uio));
> + return((*linesw[kd_tty.t_line].l_read)(tp, (struct uio
*)uio));
>
This is an unnecessary cast. I've just read device/buf.h and uio is
defined as io_req. I will send a patch removing the uio structure and
using io_req_t instead of it.
- [PATCH 08/18] kern/boot_script.c: move struct definitions to a header file, (continued)
- [PATCH 08/18] kern/boot_script.c: move struct definitions to a header file, Marin Ramesa, 2013/12/06
- [PATCH 09/18] kern/bootstrap.c: move struct definition to a header file, Marin Ramesa, 2013/12/06
- [PATCH 10/18] kern/startup.c: use boolean values, Marin Ramesa, 2013/12/06
- [PATCH 12/18] kern/debug.c: fix implicit declaration of function, Marin Ramesa, 2013/12/06
- [PATCH 11/18] kern/exception.c: move struct definition to a header file, Marin Ramesa, 2013/12/06
- [PATCH 14/18] Fix initialization from incompatible pointer type, Marin Ramesa, 2013/12/06
- Re: [PATCH 14/18] Fix initialization from incompatible pointer type,
Marin Ramesa <=
- [PATCH 13/18] kern/machine.c: fix implicit declaration of function, Marin Ramesa, 2013/12/06
- [PATCH 15/18] i386/i386at/com.c: fix initialization from incompatible pointer type, Marin Ramesa, 2013/12/06
- [PATCH 16/18] i386/i386at/com.c: fix assignment from incompatible pointer type, Marin Ramesa, 2013/12/06
- [PATCH 17/18] i386/i386at/kd_event.c: fix difference in signedness, Marin Ramesa, 2013/12/06
- [PATCH 18/18] i386/i386at/lpr.c: fix initalization from incompatible pointer type, Marin Ramesa, 2013/12/06