[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/14] i386/i386at/kd.c: remove useless old code
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 02/14] i386/i386at/kd.c: remove useless old code |
Date: |
Sun, 8 Dec 2013 23:27:12 +0900 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Mon 02 Dec 2013 22:54:40 +0100, a écrit :
> * i386/i386at/kd.c [old]: Remove code.
Unless you are sure the code should go away, don't remove it. Actually
it seems "old" code is the proper one, and the other code is a
workaround for some bogus hardware, which we may want to just drop
someday...
> ---
> i386/i386at/kd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c
> index 0b780a7..ab04632 100644
> --- a/i386/i386at/kd.c
> +++ b/i386/i386at/kd.c
> @@ -748,9 +748,7 @@ int vec;
> return;
>
> tp = &kd_tty;
> -#ifdef old
> - while ((inb(K_STATUS) & K_OBUF_FUL) == 0); /* this should never
> loop */
> -#else /* old */
> +
> {
> /*
> * Allow for keyboards that raise interrupt before
> @@ -772,7 +770,7 @@ int vec;
> while ((inb(K_STATUS) & K_OBUF_FUL) == 0)
> if (!safety--) break; /* XXX */
> }
> -#endif /* old */
> +
> /*
> * We may have seen a mouse event.
> */
> --
> 1.8.1.4
>
>
--
Samuel
> ±z¬O§_¸g±`¬°¦p¦ó©Ý®i¦æ¾PºÞ¹D¶Ë¸£µ¬?
> ¥Zµn³ø¯È,Âø»x¼s§i©Î¶l±H¢Ò¢Û (Direct Mail)¬O§_¤w¸gµLªk¹F¦¨±z¹w´Áªº¼s§i®ÄªG?
Je vous invite a consulter dans un premier temps le french-Howto.
-+- JCD in Guide du linuxien pervers - "Bien configurer la lisibilité de fcolm"