bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/66] device/blkio.c: remove function


From: Samuel Thibault
Subject: Re: [PATCH 09/66] device/blkio.c: remove function
Date: Sun, 8 Dec 2013 23:49:51 +0900
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Thu 05 Dec 2013 22:03:03 +0100, a écrit :
> Function block_io_mmap() is never a dev op, therefore it is 
> unused and it can be written again easily if needed.

> -     if (device->dev_ops->d_mmap == block_io_mmap) {
> -             d->type = DEV_PAGER_TYPE;
> -     } else {
> -             d->type = CHAR_PAGER_TYPE;
> -     }
> +     d->type = CHAR_PAGER_TYPE;

Well, since it's used in some logic, it does make sense to keep it. At
least the logic should be kept anyway.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]