[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/18] kern/debug.c: fix implicit declaration of function
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 12/18] kern/debug.c: fix implicit declaration of function |
Date: |
Mon, 9 Dec 2013 00:36:40 +0900 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Fri 06 Dec 2013 16:29:54 +0100, a écrit :
> This include fixes the implicit declaration of function. But I don't know
> if it is correct to include here stuff from i386at.
It is not, one can use <machine/model_dep.h> instead.
> * kern/debug.c: Include i386at/model_dep.h.
>
> ---
> kern/debug.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kern/debug.c b/kern/debug.c
> index e9427a3..6e15e08 100644
> --- a/kern/debug.c
> +++ b/kern/debug.c
> @@ -40,6 +40,8 @@
>
> #include <device/cons.h>
>
> +#include <i386at/model_dep.h>
> +
> #if MACH_KDB
> extern int db_breakpoints_inserted;
> #endif
> --
> 1.8.1.4
>
>
--
Samuel
"And the next time you consider complaining that running Lucid Emacs
19.05 via NFS from a remote Linux machine in Paraguay doesn't seem to
get the background colors right, you'll know who to thank."
(By Matt Welsh)
- [PATCH 05/18] vm/vm_pageout.c: remove forward declarations, (continued)
- [PATCH 05/18] vm/vm_pageout.c: remove forward declarations, Marin Ramesa, 2013/12/06
- [PATCH 06/18] vm/vm_object.c: remove unused variable, Marin Ramesa, 2013/12/06
- [PATCH 07/18] vm/vm_map.c: use boolean instead of an int, Marin Ramesa, 2013/12/06
- [PATCH 02/18] i386/i386at/lpr.c: fix argument list, Marin Ramesa, 2013/12/06
- [PATCH 08/18] kern/boot_script.c: move struct definitions to a header file, Marin Ramesa, 2013/12/06
- [PATCH 09/18] kern/bootstrap.c: move struct definition to a header file, Marin Ramesa, 2013/12/06
- [PATCH 10/18] kern/startup.c: use boolean values, Marin Ramesa, 2013/12/06
- [PATCH 12/18] kern/debug.c: fix implicit declaration of function, Marin Ramesa, 2013/12/06
- Re: [PATCH 12/18] kern/debug.c: fix implicit declaration of function,
Samuel Thibault <=
- [PATCH 11/18] kern/exception.c: move struct definition to a header file, Marin Ramesa, 2013/12/06
- [PATCH 14/18] Fix initialization from incompatible pointer type, Marin Ramesa, 2013/12/06
- [PATCH 13/18] kern/machine.c: fix implicit declaration of function, Marin Ramesa, 2013/12/06
- [PATCH 15/18] i386/i386at/com.c: fix initialization from incompatible pointer type, Marin Ramesa, 2013/12/06
- [PATCH 16/18] i386/i386at/com.c: fix assignment from incompatible pointer type, Marin Ramesa, 2013/12/06
- [PATCH 17/18] i386/i386at/kd_event.c: fix difference in signedness, Marin Ramesa, 2013/12/06