[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/28] ddb/db_mp.c (remote_db): comment the call to cpu_inter
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 24/28] ddb/db_mp.c (remote_db): comment the call to cpu_interrupt_to_db() |
Date: |
Mon, 9 Dec 2013 00:57:01 +0900 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Sun 08 Dec 2013 12:40:26 +0100, a écrit :
> This wasn't noticed before since the number of cpus is always one I guess, but
> cpu_interrupt_to_db() is without definition. Comment the call.
Well, I prefer the issue to be noticed at compilation and thus spotted
immediately rather than by the stuff not working correctly, and the poor
hacker wondering why not...
> * ddb/db_mp.c (cpu_interrupt_to_db): Comment the call.
>
> ---
> ddb/db_mp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ddb/db_mp.c b/ddb/db_mp.c
> index b99718e..1b1277e 100644
> --- a/ddb/db_mp.c
> +++ b/ddb/db_mp.c
> @@ -152,7 +152,7 @@ remote_db() {
> machine_slot[i].is_cpu &&
> machine_slot[i].running)
> {
> - cpu_interrupt_to_db(i);
> + /*cpu_interrupt_to_db(i);*/
> }
> }
> }
> --
> 1.8.1.4
>
>
--
Samuel
<P> je sens venir la fonte 14 pour le rapport
-+- #ens-mim -+-
- [PATCH 17/28] ddb/db_command.c (db_command): remove forward declaration, (continued)
- [PATCH 17/28] ddb/db_command.c (db_command): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 18/28] ddb/db_command.c (db_command_list): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 19/28] ddb/db_examine.c (db_examine_cmd): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 20/28] ddb/db_examine.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/12/08
- [PATCH 21/28] ddb/db_expr.c (db_mult_expr): remove unnecessary variable, Marin Ramesa, 2013/12/08
- [PATCH 22/28] ddb/db_expr.c (db_add_expr): remove unnecessary variable, Marin Ramesa, 2013/12/08
- [PATCH 23/28] ddb/db_mp.c: use boolean instead of an int, Marin Ramesa, 2013/12/08
- [PATCH 24/28] ddb/db_mp.c (remote_db): comment the call to cpu_interrupt_to_db(), Marin Ramesa, 2013/12/08
- Re: [PATCH 24/28] ddb/db_mp.c (remote_db): comment the call to cpu_interrupt_to_db(),
Samuel Thibault <=
- [PATCH 25/28] ddb/db_mp.c: definition of db_console() only if CONSOLE_ON_MASTER, Marin Ramesa, 2013/12/08
- [PATCH 26/28] ddb/db_print.c: use unsigned long instead of an unsigned int, Marin Ramesa, 2013/12/08
- [PATCH 27/28] Use db_addr_t instead of db_expr_t, Marin Ramesa, 2013/12/08
- [PATCH 28/28] ddb/db_trap.c (db_task_trap): remove forward declarations, Marin Ramesa, 2013/12/08
- Re: [PATCH 01/28] chips/busses.h: use boolean instead of a char, Samuel Thibault, 2013/12/08