[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/14] ddb/db_cond.c: move struct definition to a header file
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 03/14] ddb/db_cond.c: move struct definition to a header file |
|
Date: |
Mon, 9 Dec 2013 01:00:06 +0900 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Sun 08 Dec 2013 16:00:29 +0100, a écrit :
> On 08.12.2013 15:28:06, Samuel Thibault wrote:
> > Marin Ramesa, le Mon 02 Dec 2013 22:54:41 +0100, a écrit :
> > > * ddb/db_cond.c (db_cond): Move struct definition to ddb/db_cond.h.
> >
> > Why? It's not used anywhere else.
>
> I just tought it looks better this way.
Well, on the contrary: if the structure is used only in the file, it's
no used to put it in the interface, and thus the reader wondering what
it would be useful for outside the file.
Samuel
- [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/02
- [PATCH 04/14] ddb/db_macro.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
- [PATCH 05/14] i386/i386/idt.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
- [PATCH 06/14] i386/intel/pmap.c: move struct definitions to a header file, Marin Ramesa, 2013/12/02
- [PATCH 07/14] ipc/ipc_hash.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
- [PATCH 08/14] ipc/ipc_marequest.c: move struct definition to a header file, Marin Ramesa, 2013/12/02