Re: [PATCH 05/29] device/blkio.c (block_io): check if io

bug-hurd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger

From:	Samuel Thibault
Subject:	Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero
Date:	Tue, 10 Dec 2013 00:48:26 +0100
User-agent:	Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Mon 09 Dec 2013 23:57:20 +0100, a écrit :
> Check if member io_count is non-negative.

Can it really be negative?  I don't see existing functions test for
that, so maybe it should be an unsigned long actually, and it's creators
of ior structures which should make sure they don't stuff negative
values there.

Samuel

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 01/29] i386: move prototypes to fix implicit declaration of function, Marin Ramesa, 2013/12/09
- [PATCH 02/29] i386/i386at/kd_event.c (kbdsetstat): fix difference in signedness, Marin Ramesa, 2013/12/09
- [PATCH 04/29] i386/i386/db_trace.c: use long instead of an int, Marin Ramesa, 2013/12/09
  - Re: [PATCH 04/29] i386/i386/db_trace.c: use long instead of an int, Samuel Thibault, 2013/12/09
- [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
  - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Samuel Thibault <=
    - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
    - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Samuel Thibault, 2013/12/10
- [PATCH 03/29] i386/i386/db_interface.c: use vm_offset_t instead of an unsigned int, Marin Ramesa, 2013/12/09
  - Re: [PATCH 03/29] i386/i386/db_interface.c: use vm_offset_t instead of an unsigned int, Samuel Thibault, 2013/12/09
- [PATCH 06/29] device/chario.c (char_write): check if io_count is larger or equal to zero and cast it to vm_size_t, Marin Ramesa, 2013/12/09
- [PATCH 07/29] device/chario.c (char_read): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
- [PATCH 08/29] device/chario.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/12/09
- [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char, Marin Ramesa, 2013/12/09
  - Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char, Samuel Thibault, 2013/12/09
- [PATCH 10/29] device/cirbuf.c (cb_alloc): use vm_size_t instead of an int, Marin Ramesa, 2013/12/09

Prev by Date: Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char
Next by Date: Re: [PATCH 16/29] device/dev_pager.c (device_pager_data_request_done): check if io_residual is larger or equal to zero and cast it to size_t
Previous by thread: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero
Next by thread: Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero
Index(es):
- Date
- Thread