Re: [PATCH 6/6] i386/i386/db_trace.c (db_i386_reg_value): cast to (int *) instead to (long *)

[Samuel Thibault]

Marin Ramesa, le Thu 12 Dec 2013 18:27:08 +0100, a écrit :
> This quiets the GCC warning about passing from incompatible pointer type.
> 
> * i386/i386/db_trace.c (db_i386_reg_value) (db_lookup_i386_kreg) (STACK_IKS): 
> Cast to (int *) instead to (long *).

db_lookup_i386_kreg should actually rather be fixed into taking long*,
that's what it'll take in the 64bit port.

> ---
>  i386/i386/db_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/i386/i386/db_trace.c b/i386/i386/db_trace.c
> index 6247d4f..75f49da 100644
> --- a/i386/i386/db_trace.c
> +++ b/i386/i386/db_trace.c
> @@ -148,7 +148,7 @@ db_i386_reg_value(
>           } else if ((thread->state & TH_SWAPPED) == 0 &&
>                       thread->kernel_stack) {
>               dp = db_lookup_i386_kreg(vp->name,
> -                             (long *)(STACK_IKS(thread->kernel_stack)));
> +                             (int *)(STACK_IKS(thread->kernel_stack)));
>               if (dp == 0)
>                   dp = &null_reg;
>           } else if ((thread->state & TH_SWAPPED) &&
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
<D> I hated the Mighty Mouse in the Apple Store every time I played with it. I 
hated the Mighty Mouse at work whenever I set up a Mac for somebody.
<D> I decided to give it one last chance when I set up my new Mac
<D> And golly, I like it at home.
<D> Maybe mine is defective in a way that makes it good.