[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns
From: |
Marin Ramesa |
Subject: |
Re: [PATCH 3/6] ddb/db_break.c (db_delete_cmd): add missing returns |
Date: |
Sun, 15 Dec 2013 22:38:29 +0100 |
On 15.12.2013 20:25:24, Samuel Thibault wrote:
> Marin Ramesa, le Sun 15 Dec 2013 20:22:02 +0100, a écrit :
> > On 15.12.2013 20:14:03, Samuel Thibault wrote:
> > > Marin Ramesa, le Thu 12 Dec 2013 18:27:05 +0100, a écrit :
> > > > There is a code path when db_error() can return.
> > >
> > > Which one?
> >
> > When _longjmp()
>
> _longjmp never returns.
GCC seems to think it can return and I was fooled by that comment in
_setjmp.S. Anyway, writing returns quiets the warning.
[PATCH 4/6] ddb/db_break.c (db_delete_cmd): remove unnecessary initialization, Marin Ramesa, 2013/12/12
[PATCH 5/6] ddb/db_expr.c (db_mult_expr): initialize lhs, Marin Ramesa, 2013/12/12
[PATCH 6/6] i386/i386/db_trace.c (db_i386_reg_value): cast to (int *) instead to (long *), Marin Ramesa, 2013/12/12