Re: [PATCH 2/2] ddb/db_command.c (db_help_cmd): mark with attribute unused

[Samuel Thibault]

Marin Ramesa, le Thu 19 Dec 2013 18:51:06 +0100, a écrit :
> * ddb/db_command.c (db_help_cmd): Mark with attribute unused.

Err, well, no, on the contrary. Marking the function as unused silences
the warning, and thus maintainers won't realize any more that it is
unused, and thus the probability of somebody dropping the function
actually decreases.

> ---
>  ddb/db_command.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ddb/db_command.c b/ddb/db_command.c
> index 3257e07..74134fb 100644
> --- a/ddb/db_command.c
> +++ b/ddb/db_command.c
> @@ -382,7 +382,7 @@ struct db_command *ptr;
>  
>  struct db_command    *db_last_command = 0;
>  
> -void
> +void __attribute__ ((unused))
>  db_help_cmd(void)
>  {
>       struct db_command *cmd = db_command_table;
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
(03:13:14) <j> bon
(03:13:19) <j> il est tard :p
(03:13:25) <g> c'est l'heure de manger
(03:13:38) <j> hm j'ai mangé à 1h moi, j'ai des horaires raisonnables