Re: [PATCH 4/8] ipc: use the name of the task for error messages

[Samuel Thibault]

Justus Winter, le Sat 01 Feb 2014 15:09:24 +0100, a écrit :
> * ipc/mach_port.c (mach_port_destroy): Use the name of the task for
> error messages.
> (mach_port_deallocate): Likewise.

Ack.

> ---
>  ipc/mach_port.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ipc/mach_port.c b/ipc/mach_port.c
> index fbc5e69..13572a1 100644
> --- a/ipc/mach_port.c
> +++ b/ipc/mach_port.c
> @@ -571,7 +571,7 @@ mach_port_destroy(
>       kr = ipc_right_lookup_write(space, name, &entry);
>       if (kr != KERN_SUCCESS) {
>               if (name != MACH_PORT_NULL && name != MACH_PORT_DEAD && space 
> == current_space()) {
> -                     printf("task %p destroying an invalid port %lu, most 
> probably a bug.\n", current_task(), name);
> +                     printf("task %.*s destroying an invalid port %lu, most 
> probably a bug.\n", sizeof current_task()->name, current_task()->name, name);
>                       if (mach_port_deallocate_debug)
>                               SoftDebugger("mach_port_deallocate");
>               }
> @@ -615,7 +615,7 @@ mach_port_deallocate(
>       kr = ipc_right_lookup_write(space, name, &entry);
>       if (kr != KERN_SUCCESS) {
>               if (name != MACH_PORT_NULL && name != MACH_PORT_DEAD && space 
> == current_space()) {
> -                     printf("task %p deallocating an invalid port %lu, most 
> probably a bug.\n", current_task(), name);
> +                     printf("task %.*s deallocating an invalid port %lu, 
> most probably a bug.\n", sizeof current_task()->name, current_task()->name, 
> name);
>                       if (mach_port_deallocate_debug)
>                               SoftDebugger("mach_port_deallocate");
>               }
> -- 
> 1.8.5.2
> 

-- 
Samuel
<P> moo
<N> moo ?
<D> P: keski t'arrive? :))
<P> moooo
<N> moooooo ?
<P> rien le net marche je suis content :)
 -+- #ens-mim - accro du net -+-