[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 5/9] ext2fs: fix type of inum

From: Justus Winter
Subject: [PATCH 5/9] ext2fs: fix type of inum
Date: Mon, 28 Apr 2014 12:20:00 +0200

Previously, inum was of type int, whereas dino_ref expects ino_t.  On
Hurd/x86 the former is 32 bit wide, the latter 64.  If dino_ref is
inlined, this does not seem to pose a problem, but if ext2fs is
compiled with -O0, this most likely results in an invalid memory access.

* ext2fs/ialloc.c (ext2_alloc_inode): Use type ino_t for inum.
 ext2fs/ialloc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ext2fs/ialloc.c b/ext2fs/ialloc.c
index 2d8e51e..52212d5 100644
--- a/ext2fs/ialloc.c
+++ b/ext2fs/ialloc.c
@@ -115,7 +115,8 @@ ino_t
 ext2_alloc_inode (ino_t dir_inum, mode_t mode)
   char *bh = NULL;
-  int i, j, inum, avefreei;
+  int i, j, avefreei;
+  ino_t inum;
   struct ext2_group_desc *gdp;
   struct ext2_group_desc *tmp;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]