[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] libdiskfs: add diskfs_make_node_alloc to allocate fat no
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 1/4] libdiskfs: add diskfs_make_node_alloc to allocate fat nodes |
|
Date: |
Tue, 20 May 2014 21:25:10 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Hello,
Justus Winter, le Sun 18 May 2014 15:24:52 +0200, a écrit :
> - ino64_t cache_id;
> -
> int author_tracks_uid;
> +
> + /* This is the last field. We do this so that if the node is
> + allocated with the disknode in an contiguous block, it sits right
> + next to the user supplied data. */
> + ino64_t cache_id;
Is this really needed? It breaks the current ABI, while AIUI one could
just use sizeof(struct node) - offsetof(cache_id,struct node)
Samuel