Re: [PATCH 1/4] libdiskfs: add diskfs_make_node_alloc to allocate fat nodes

[Justus Winter]

Quoting Samuel Thibault (2014-05-20 21:25:10)
> Hello,
> 
> Justus Winter, le Sun 18 May 2014 15:24:52 +0200, a écrit :
> > -  ino64_t cache_id;
> > -
> >    int author_tracks_uid;
> > +
> > +  /* This is the last field.  We do this so that if the node is
> > +     allocated with the disknode in an contiguous block, it sits right
> > +     next to the user supplied data.  */
> > +  ino64_t cache_id;
> 
> Is this really needed?

No, it just makes it less likely that the cache_id ends up in another
cache line than the disknode.

> It breaks the current ABI, while AIUI one could just use
> sizeof(struct node) - offsetof(cache_id,struct node)

Sure.

Justus