[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/11] libstore: provide function declaration until available
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 06/11] libstore: provide function declaration until available upstream |
|
Date: |
Thu, 29 May 2014 23:24:26 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Fri 23 May 2014 08:39:56 +0200, a écrit :
> Quoting Samuel Thibault (2014-05-23 00:22:14)
> > Justus Winter, le Thu 22 May 2014 22:13:28 +0200, a écrit :
> > > Until the Hurd specific header is available, provide a local
> > > declaration of ped_device_new_from_store.
> >
> > Mmm, does it really fix something? I'd prefer to keep the warning
> > showing up, so somebody eventually takes the time to provide a header.
> > Otherwise we'll just hide a warning, and possibly nobody will eventually
> > take the time to actually fix it.
>
> With this change, Hurd compiles with -Werror=implicit.
Then I'd say put a #warning next to the added declaration :)
Samuel
- [PATCH 07/11] Avoid compiler warning about empty bodies, (continued)
- [PATCH 07/11] Avoid compiler warning about empty bodies, Justus Winter, 2014/05/22
- [PATCH 09/11] libnetfs: add netfs_make_node_alloc to allocate fat nodes, Justus Winter, 2014/05/22
- [PATCH 03/11] pfinet: add missing include, Justus Winter, 2014/05/22
- [PATCH 05/11] libdiskfs: fix type of dir_cache_id, node_cache_id, Justus Winter, 2014/05/22
- [PATCH 06/11] libstore: provide function declaration until available upstream, Justus Winter, 2014/05/22
- [PATCH 08/11] libdiskfs: add diskfs_make_node_alloc to allocate fat nodes, Justus Winter, 2014/05/22
- [PATCH 04/11] term: fix memory leak, Justus Winter, 2014/05/22
- [PATCH 10/11] trans/fakeroot: use fat nodes to simplify the node cache, Justus Winter, 2014/05/22
- [PATCH 11/11] trans/fakeroot: use netfs_node_netnode instead of np->nn, Justus Winter, 2014/05/22
- Re: [PATCH 01/11] include: install refcount.h, Samuel Thibault, 2014/05/22