Re: [PATCH 1/9] include: use unsigned literal in combination with binary not

[Samuel Thibault]

Justus Winter, le Fri 06 Jun 2014 16:42:10 +0200, a écrit :
> * include/refcount.h (refcounts_promote): Use ~0U.
> (refcounts_demote): Likewise.

Ack.

> ---
>  include/refcount.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/refcount.h b/include/refcount.h
> index 5c3302d..785b052 100644
> --- a/include/refcount.h
> +++ b/include/refcount.h
> @@ -160,7 +160,7 @@ refcounts_promote (refcounts_t *ref, struct references 
> *result)
>       So we just add a hard reference.  In combination, this is the
>       desired operation.  */
>    const union _references op =
> -    { .references = { .weak = ~0, .hard = 1} };
> +    { .references = { .weak = ~0U, .hard = 1} };
>    union _references r;
>    r.value = __atomic_add_fetch (&ref->value, op.value, __ATOMIC_RELAXED);
>    assert (r.references.hard != UINT32_MAX || !"refcount overflowed!");
> @@ -188,7 +188,7 @@ refcounts_demote (refcounts_t *ref, struct references 
> *result)
>       significant bits.  When we add ~0 to the hard references, it will
>       overflow into the weak references.  This is the desired
>       operation.  */
> -  const union _references op = { .references = { .hard = ~0 } };
> +  const union _references op = { .references = { .hard = ~0U } };
>    union _references r;
>    r.value = __atomic_add_fetch (&ref->value, op.value, __ATOMIC_RELAXED);
>    assert (r.references.hard != UINT32_MAX || !"refcount underflowed!");
> -- 
> 2.0.0.rc2
> 

-- 
Samuel
 > Quelqu'un aurait-il une solution pour réinitialiser un MBR
 Si tu veux qu'il soit complètement blanc (pas souhaitable, à mon avis) :
 dd if=/dev/zero of=/dev/hda bs=512 count=1 (sous Linux)
 -+- OT in Guide du linuxien (très) pervers - "Pour les K difficiles" -+-