Re: [PATCH 2/6] ddb: print task names if available

[Samuel Thibault]

Justus Winter, le Mon 09 Jun 2014 18:38:31 +0200, a écrit :
> * ddb/db_print.c (db_print_task): Print task name if available.
> * i386/i386/db_interface.c (db_task_name): Likewise.

Ack.

You can also drop the DB_GNUMACH_TASK_NAME definition, which is not used
any more then.

> ---
>  ddb/db_print.c           | 7 ++++++-
>  i386/i386/db_interface.c | 4 ++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/ddb/db_print.c b/ddb/db_print.c
> index c015d84..1cbff64 100644
> --- a/ddb/db_print.c
> +++ b/ddb/db_print.c
> @@ -258,7 +258,12 @@ db_print_task(
>       } else {
>           if (flag & OPTION_TASK_TITLE)
>               db_printf("    TASK        THREADS\n");
> -         db_printf("%3d (%0*X): ", task_id, 2*sizeof(vm_offset_t), task);
> +         if (task->name[0])
> +             db_printf("%3d %s (%0*X): ", task_id, task->name,
> +                       2*sizeof(vm_offset_t), task);
> +         else
> +             db_printf("%3d (%0*X): ", task_id,
> +                       2*sizeof(vm_offset_t), task);
>           if (task->thread_count == 0) {
>               db_printf("no threads\n");
>           } else {
> diff --git a/i386/i386/db_interface.c b/i386/i386/db_interface.c
> index 1337685..b442b86 100644
> --- a/i386/i386/db_interface.c
> +++ b/i386/i386/db_interface.c
> @@ -730,8 +730,8 @@ db_task_name(
>       vm_offset_t vaddr, kaddr;
>       unsigned sp;
>  
> -     if (task->map->pmap == kernel_pmap) {
> -             db_printf(DB_GNUMACH_TASK_NAME);
> +     if (task->name[0]) {
> +             db_printf("%s", task->name);
>               return;
>       }
>  
> -- 
> 2.0.0
> 
> 

-- 
Samuel
 Moralité : le modem et le cablerouteur font comme les filles, ils
 papotent toute la journée.
 -+- RB in NPC : Et en plus, ils ne parlent que de bits -+-