Re: [PATCH] utils/mount: canonicalize mountpoints

[Gabriele Giacone]

On Sun, Jun 15, 2014 at 1:59 AM, Samuel Thibault
<samuel.thibault@gnu.org> wrote:
> Gabriele Giacone, le Sun 15 Jun 2014 01:28:06 +0200, a écrit :
>> ... this one would fix malformed mount/umount input paths (another
>> source. Any else? raw settrans). It would make first and last hunks in
>> pbuilder.diff [0] useless.
>>
>> [0] https://lists.debian.org/debian-hurd/2014/06/msg00032.html
>
> Ok, so now the goal is known.  How is it achieved?
>
> I'm sorry, but either you explain in details, or I have to take the time
> to work it out by myself, it's as simple as that.  It's already late for
> me, and I have to wake up early tomorrow, etc.

I thought it was already detailed enough: first and last hunks useless
if patch is applied are:

@@ -73,7 +73,7 @@ if ! ( cd "$BUILDPLACE" && \
     --include=apt \
     "${DEBOOTSTRAPOPTS[@]}" \
     "$DISTRIBUTION" \
-    . \
+    "$BUILDPLACE" \
     "$MIRRORSITE" \
     $DEBOOTSTRAPSCRIPT ) ; then
     log "E: $DEBOOTSTRAP failed"
and
@@ -4,7 +4,7 @@
 BASETGZ=/var/cache/pbuilder/base.tgz
 #EXTRAPACKAGES=""
 #export DEBIAN_BUILDARCH=athlon
-BUILDPLACE=/var/cache/pbuilder/build/
+BUILDPLACE=/var/cache/pbuilder/build
 MIRRORSITE=http://cdn.debian.net/debian
 #OTHERMIRROR="deb http://www.home.com/updates/ ./"
 #export http_proxy=http://your-proxy:8080/

Such hunks are workarounds at the moment because hurd mounts paths by
keeping superfluous '/' and '.' in pathnames if specified at mount
time, which need to be specified at umount time as well to umount
successfully.

Patch simply makes mount/umount utilities fix through realpath
mountpoints/device pathnames to pass to settrans, making workarounds
above useless.

-- 
G..e