[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support invoking the debugger over the serial console
From: |
Neal H. Walfield |
Subject: |
Re: [PATCH] Support invoking the debugger over the serial console |
Date: |
Fri, 22 Aug 2014 10:10:14 +0200 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
At Thu, 21 Aug 2014 13:16:01 +0200,
Samuel Thibault wrote:
>
> Hello,
>
> Thanks for sharing, I've had this kind of patch in my tree for a long
> with another, easier to parse, keypress, but this implementation seems
> nice as it keeps it ctrl-alt-d.
>
> Justus Winter, le Thu 21 Aug 2014 12:14:50 +0200, a écrit :
> > if (tp->t_state&TS_ISOPEN) {
> > + int escape = 0;
> > while ((line = inb(LINE_STAT(addr))) & iDR) {
> > c = inb(TXRX(addr));
> > - ttyinput(c, tp);
> > +
> > + if (c == 0x1b) {
> > + escape = 1;
> > + continue;
> > + }
>
> Mmm, but this means that an escape alone will be lost, which is a real
> problem for e.g. using vim :) Can't escape rather be an static array
> indexed by unit number?
>
> > +#if MACH_KDB
> > + if (escape && c == 4)
>
> I like using 'C'-'@' instead of the magic-looking 4 :)
Even better:
'D' - ('A' - 1)
Neal