Re: [PATCH 4/7] procfs: do not test whether /hurd/mtab exists

[Samuel Thibault]

Justus Winter, le Mon 22 Sep 2014 11:38:41 +0200, a écrit :
> Now that procfs is merged into the Hurd repository we can just assume
> that the mtab translator exists.

Ack

> * procfs/rootdir.c (rootdir_mounts_exists): Drop function.
> (rootdir_entries): Adjust accordingly.
> ---
>  procfs/rootdir.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/procfs/rootdir.c b/procfs/rootdir.c
> index f92e73d..81e36f7 100644
> --- a/procfs/rootdir.c
> +++ b/procfs/rootdir.c
> @@ -463,15 +463,6 @@ rootdir_mounts_get_translator (void *hook, char **argz, 
> size_t *argz_len)
>    return 0;
>  }
>  
> -static int
> -rootdir_mounts_exists (void *dir_hook, const void *entry_hook)
> -{
> -  static int translator_exists = -1;
> -  if (translator_exists == -1)
> -    translator_exists = access (_HURD_MTAB, F_OK|X_OK) == 0;
> -  return translator_exists;
> -}
> -
>  static error_t
>  rootdir_gc_slabinfo (void *hook, char **contents, ssize_t *contents_len)
>  {
> @@ -674,7 +665,6 @@ static const struct procfs_dir_entry rootdir_entries[] = {
>      },
>      .ops = {
>        .make_node = rootdir_mounts_make_node,
> -      .exists = rootdir_mounts_exists,
>      }
>    },
>    {
> -- 
> 2.1.0
> 

-- 
Samuel
/*
 * [...] Note that 120 sec is defined in the protocol as the maximum
 * possible RTT.  I guess we'll have to use something other than TCP
 * to talk to the University of Mars.
 * PAWS allows us longer timeouts and large windows, so once implemented
 * ftp to mars will work nicely.
 */
(from /usr/src/linux/net/inet/tcp.c, concerning RTT [retransmission timeout])