[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/7] procfs: provide magic retry response for /proc/self

From: Roland McGrath
Subject: Re: [PATCH 7/7] procfs: provide magic retry response for /proc/self
Date: Wed, 1 Oct 2014 13:54:14 -0700 (PDT)

> > +     "proc/self/..." means replace `proc/self' with the PID of the current
> > +                process and then retry as for FS_RETRY_NORMAL.
> Roland, does it look OK to use a FS_RETRY_MAGICAL for implementing
> /proc/self?

FS_RETRY_MAGICAL is appropriate.  But the string itself should more
generally describe what it means rather than referring to a specific use
case, and should definitely not contain a slash.  I'd use just "pid" or
perhaps "self-pid" (but it's not "self-tty", so "pid" is probably right).
The description should be complete and not leave details to the imagination
or presumption: here the omitted detail is the formatting of the number;
you can say "in minimal decimal" or you can say "in %u format" to
unambiguously mean the same thing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]