bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH hurd-dde 2/7] Remove obsolete device server stubs


From: Samuel Thibault
Subject: Re: [PATCH hurd-dde 2/7] Remove obsolete device server stubs
Date: Wed, 26 Nov 2014 18:47:30 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Justus Winter, le Wed 26 Nov 2014 15:22:31 +0100, a écrit :
> Remove server implementations for the obsolete RPCs
> `xxx_device_set_status', `xxx_device_get_status', and
> `xxx_device_set_filter'.

Ack.

> * devnode/devnode.c: Remove obsolete device server stubs.
> * eth-filter.multi-thread/filter.c: Likewise.
> * eth-filter/filter.c: Likewise.
> * eth-multiplexer/device_impl.c: Likewise.
> * libmachdev/ds_routines.c: Likewise.
> ---
>  devnode/devnode.c                | 21 ---------------------
>  eth-filter.multi-thread/filter.c | 21 ---------------------
>  eth-filter/filter.c              | 21 ---------------------
>  eth-multiplexer/device_impl.c    | 26 --------------------------
>  libmachdev/ds_routines.c         | 35 -----------------------------------
>  5 files changed, 124 deletions(-)
> 
> diff --git a/devnode/devnode.c b/devnode/devnode.c
> index 789bf51..f9f0359 100644
> --- a/devnode/devnode.c
> +++ b/devnode/devnode.c
> @@ -138,27 +138,6 @@ do_mach_notify_dead_name (struct port_info *pi,
>  }
>  
>  /* Implementation of device interface */
> -kern_return_t 
> -ds_xxx_device_set_status (device_t device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t statu_cnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_get_status (device_t device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t *statuscnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_set_filter (device_t device, mach_port_t rec,
> -                       int pri, filter_array_t filt, size_t len)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
>  kern_return_t
>  ds_device_open (mach_port_t master_port, mach_port_t reply_port,
>               mach_msg_type_name_t reply_portPoly,
> diff --git a/eth-filter.multi-thread/filter.c 
> b/eth-filter.multi-thread/filter.c
> index ec3efe9..5a6d589 100644
> --- a/eth-filter.multi-thread/filter.c
> +++ b/eth-filter.multi-thread/filter.c
> @@ -315,27 +315,6 @@ do_mach_notify_dead_name (mach_port_t notify,
>  }
>  
>  /* Implementation of device interface */
> -kern_return_t 
> -ds_xxx_device_set_status (device_t device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t statu_cnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_get_status (device_t device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t *statuscnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_set_filter (device_t device, mach_port_t rec,
> -                       int pri, filter_array_t filt, size_t len)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
>  kern_return_t
>  ds_device_open (mach_port_t master_port, mach_port_t reply_port,
>               mach_msg_type_name_t reply_portPoly,
> diff --git a/eth-filter/filter.c b/eth-filter/filter.c
> index 482b080..13dd03b 100644
> --- a/eth-filter/filter.c
> +++ b/eth-filter/filter.c
> @@ -294,27 +294,6 @@ do_mach_notify_dead_name (struct port_info *pi,
>  }
>  
>  /* Implementation of device interface */
> -kern_return_t 
> -ds_xxx_device_set_status (struct proxy_user *device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t statu_cnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_get_status (struct proxy_user *device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t *statuscnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_set_filter (struct proxy_user *device, mach_port_t rec,
> -                       int pri, filter_array_t filt, size_t len)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
>  kern_return_t
>  ds_device_open (mach_port_t master_port, mach_port_t reply_port,
>               mach_msg_type_name_t reply_portPoly,
> diff --git a/eth-multiplexer/device_impl.c b/eth-multiplexer/device_impl.c
> index 35a4da4..7d82b8d 100644
> --- a/eth-multiplexer/device_impl.c
> +++ b/eth-multiplexer/device_impl.c
> @@ -39,32 +39,6 @@ extern struct port_class *other_portclass;
>  extern struct port_info *notify_pi;
>  
>  /* Implementation of device interface */
> -kern_return_t
> -ds_xxx_device_set_status (struct vether_device *vdev, dev_flavor_t flavor,
> -                       dev_status_t status, size_t statu_cnt)
> -{
> -  if (vdev == NULL)
> -    return D_NO_SUCH_DEVICE;
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_get_status (struct vether_device *vdev, dev_flavor_t flavor,
> -                       dev_status_t status, size_t *statuscnt)
> -{
> -  if (vdev == NULL)
> -    return D_NO_SUCH_DEVICE;
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_set_filter (struct vether_device *vdev, mach_port_t rec,
> -                       int pri, filter_array_t filt, size_t len)
> -{
> -  if (vdev == NULL)
> -    return D_NO_SUCH_DEVICE;
> -  return D_INVALID_OPERATION;
> -}
>  
>  /*
>   * This function is currently running in the multithread environment,
> diff --git a/libmachdev/ds_routines.c b/libmachdev/ds_routines.c
> index 6bd5a12..5287bf4 100644
> --- a/libmachdev/ds_routines.c
> +++ b/libmachdev/ds_routines.c
> @@ -98,41 +98,6 @@ mach_convert_device_to_port (mach_device_t device)
>  }
>  
>  /* Implementation of device interface */
> -kern_return_t 
> -ds_xxx_device_set_status (struct mach_device *device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t statu_cnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_get_status (struct mach_device *device, dev_flavor_t flavor,
> -                       dev_status_t status, size_t *statuscnt)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_xxx_device_set_filter (struct mach_device *device, mach_port_t rec,
> -                       int pri, filter_array_t filt, size_t len)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -io_return_t
> -ds_device_intr_register (mach_port_t master_port, int irq,
> -                      int flags, int id, mach_port_t receive_port)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
> -kern_return_t
> -ds_device_intr_enable (mach_port_t master_port,
> -                    int line, char status)
> -{
> -  return D_INVALID_OPERATION;
> -}
> -
>  io_return_t
>  ds_device_open (mach_port_t open_port, mach_port_t reply_port,
>               mach_msg_type_name_t reply_port_type, dev_mode_t mode,
> -- 
> 2.1.3
> 

-- 
Samuel
<Raize> can you guys see what I type?
<vecna> no, raize
<Raize> How do I set it up so you can see it?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]