[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH hurd 01/30] proc: fix NULL dereference
From: |
Samuel Thibault |
Subject: |
Re: [PATCH hurd 01/30] proc: fix NULL dereference |
Date: |
Thu, 27 Nov 2014 19:17:17 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Thu 27 Nov 2014 14:18:41 +0100, a écrit :
> This also restores the behavior before e9687ec4.
>
> * proc/notify.c (do_mach_notify_dead_name): Fix NULL dereference.
I had actually already commited the same :)
> ---
> proc/notify.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/proc/notify.c b/proc/notify.c
> index b6731ae..f179423 100644
> --- a/proc/notify.c
> +++ b/proc/notify.c
> @@ -41,6 +41,9 @@ do_mach_notify_dead_name (struct port_info *pi,
> {
> struct proc *p;
>
> + if (! pi)
> + return EOPNOTSUPP;
> +
> if (pi->port_right == generic_port)
> {
> check_dead_execdata_notify (deadport);
> @@ -50,9 +53,7 @@ do_mach_notify_dead_name (struct port_info *pi,
>
> p = (struct proc *) pi;
>
> - if (!p
> - || p->p_pi.bucket != proc_bucket
> - || p->p_pi.class != proc_class)
> + if (p->p_pi.bucket != proc_bucket || p->p_pi.class != proc_class)
> return EOPNOTSUPP;
>
> if (p->p_task == deadport)
> --
> 2.1.3
>
--
Samuel
<b> il faut combien de chevaux pour tirer une doloréan à 88 morph ?
***b vient de remarque que 88 mph c'est 142 km/h
<y> aaaaah
<y> c'est pour ça qu'ils limitent à 130 km/h sur les autoroutes
<y> c'est pour éviter que les gens voyagent dans le temps
<b> probablement
- [PATCH hurd 22/30] trans/ifsock: add a payload-aware intrans function, (continued)
- [PATCH hurd 22/30] trans/ifsock: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 20/30] term: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 24/30] trans/streamio: make the translator payload-aware, Justus Winter, 2014/11/27
- [PATCH hurd 29/30] libports: Fix build, Justus Winter, 2014/11/27
- [PATCH hurd 25/30] trans/symlink: disable default payload to port mapping, Justus Winter, 2014/11/27
- [PATCH hurd 27/30] hurd: add intranpayload functions to all hurd types, Justus Winter, 2014/11/27
- [PATCH hurd 26/30] utils/rpctrace: make `trace_and_forward' payload-aware, Justus Winter, 2014/11/27
- [PATCH hurd 30/30] mach-defpager: fix build, Justus Winter, 2014/11/27
- [PATCH hurd 28/30] libports: use protected payloads to optimize the object lookup, Justus Winter, 2014/11/27
- [PATCH hurd 07/30] libnetfs: add a payload-aware intrans function, Justus Winter, 2014/11/27
- Re: [PATCH hurd 01/30] proc: fix NULL dereference,
Samuel Thibault <=
- [PATCH hurd-dde 1/4] devnode: add a payload-aware intrans function, Justus Winter, 2014/11/27