[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH hurd 02/30] include: force all refcount functions to be inlin
|
From: |
Justus Winter |
|
Subject: |
Re: [PATCH hurd 02/30] include: force all refcount functions to be inlined |
|
Date: |
Sun, 30 Nov 2014 19:29:01 +0100 |
|
User-agent: |
alot/0.3.5 |
Quoting Samuel Thibault (2014-11-27 19:18:35)
> Justus Winter, le Thu 27 Nov 2014 14:18:42 +0100, a écrit :
> > * include/refcount.h: Declare all functions `extern inline' instead of
> > `static inline'. This forces those functions to be inlined,
>
> Well, actually no. The compiler is still allowed not to inline them,
> and that turns them into external references.
Crap. That must have been wishful thinking on my part ;)
> You then need to make some .c file provide the implementations. See
> for instance the use of DISKFS_DEFINE_EXTERN_INLINE
Yes, I'm introducing this for libports too. When I introduced
refcount.h I didn't realized that gcc doesn't approve of me using a
static inline function in a extern inline one (that we're using all
over the place). So where would I put this then? libports?
Justus
- Protected payloads for the Hurd servers, Justus Winter, 2014/11/27
- [PATCH hurd 04/30] libports: add `ports_lookup_payload' and `ports_payload_get_name', Justus Winter, 2014/11/27
- [PATCH hurd 05/30] libports: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 06/30] libdiskfs: add payload-aware intrans functions, Justus Winter, 2014/11/27
- [PATCH hurd 09/30] libpager: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 08/30] libtrivfs: add payload-aware intrans functions, Justus Winter, 2014/11/27
- [PATCH hurd 11/30] auth: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 10/30] libcons: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 12/30] console: add a payload-aware intrans function, Justus Winter, 2014/11/27
- [PATCH hurd 13/30] console-client: make the demuxer payload-aware, Justus Winter, 2014/11/27