bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: [PATCH] trans/fakeroot.c


From: Svante Signell
Subject: Re: RFC: [PATCH] trans/fakeroot.c
Date: Tue, 09 Jun 2015 10:13:46 +0200

On Fri, 2015-06-05 at 11:18 +0530, Samuel Thibault wrote:
> Hello,
> 
> It seems there is still a corner case which doesn't work: the pycorrfit
> package fails to build with:
> 
> chmod -R 644 
> debian/pycorrfit/usr/share/doc/pycorrfit/examples/external_model_functions/
> chmod: cannot access 
> 'debian/pycorrfit/usr/share/doc/pycorrfit/examples/external_model_functions/ExampleFunc_CS_2D+2D+S+T.txt':
>  Permission denied
> 
> etc.  Could you have a look?

Done so now. Attached are two versions of a patch to fakeroot.c. In
netfs_get_dirents(): call netfs_attempt_chmod() before dir_readdir() to
make sure that directories are accessible (executable) before changing
the underlying files. The resulting directory (and file) access
permissions are the same as with fakeroot-tcp and Linux.
The first patch adds S_IXUSR to real_mode, the other adds O_EXEC to
nn->openmodes. Your choice (if OK, of course, maybe I've missed
something.)

Thanks!

Attachment: trans_fakeroot_v1.patch
Description: Text Data

Attachment: trans_fakeroot_v2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]