Re: [PATCH] Fix race condition in ext2fs when remounting

[James Clarke]

Perhaps; I was following what diskfs_remount does when inhibiting RPCs, which 
stay inhibited on error.

James

> On 23 Jul 2015, at 00:51, Diego Nieto Cid <dnietoc@gmail.com> wrote:
> 
> Hi
> 
> This is me being picky about a corner case :-)
> 
> 2015-07-22 19:42 GMT-03:00 James Clarke <jrtc27@jrtc27.com>:
>> +error_t
>> +inhibit_ext2_pager (void)
>> +{
>> +  error_t err;
>> +
>> +  /* The file pager can rely on the disk pager, so inhibit the file
>> +     pager first.  */
>> +
>> +  err = pager_inhibit_workers (file_pager_requests);
>> +  if (err)
>> +    return err;
>> +
>> +  err = pager_inhibit_workers (diskfs_disk_pager_requests);
>> +  return err;
>> +}
> 
> It looks like the file pager workers will remain inhibited if the
> 'pager_inhibit_workers' function
> fails to inhibit the disk pager. fatfs is affected by this problem too.
> 
> Should a call to 'pager_resume_workers' be inserted before returning
> in case of error?
> 
> Regards