[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Rump on GNU/Hurd (4): Userspace PCI I/O

From: Antti Kantee
Subject: Re: [PATCH] Rump on GNU/Hurd (4): Userspace PCI I/O
Date: Sun, 16 Aug 2015 13:14:57 +0000

On 16/08/15 11:09, Robert Millan wrote:


This patch adds GNU/Hurd support to pci-userspace. Some notes:

* It uses libpciaccess to query/modify the PCI config stuff. This part of the 
code is pretty
   generic, perhaps this approach can be useful to other ports?


* It includes code from other people under GPLv2; I'm not sure if this may be 
an issue wrt licensing
   policy of Rump as this is only targetted at the pci-userspace module. In any 
case if you
   think it's an issue let me know and we'll try to find a solution:
   - intrthread() is heavily based on intloop() from hurd/libddekit/interrupt.c
   - experimentalUser.c is an automatically generated file copied from the Hurd 
build tree. I
     would welcome some help from MIG experts on how to do this in a more 
elegant way.
   - intr.h was just copied from GNU Mach source tree (I don't think it is 

I'm not worried about GPL, but I am worried about someone using GPL accidentally when they did not intend to. It's better if the code can offered under LGLP, but not a requirement. One option would be to put Hurd support under "gpl/src-hurd". Or just be very explicit about the licensing both in LICENSE and README.

Can you make sure your code is properly formatted (space vs. tab). Also, there's at least one copypasted comment which is no longer valid.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]