Re: [RFC] Fix printk not handling ANSI escape codes

[James Clarke]

Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd is 
actually using escape codes.

I was trying to decide whether putc should handle escape codes or whether it 
should be left as outputting raw bytes to the display. As you can see I chose 
the latter, but do you think that was the right decision?

James

> On 29 Aug 2015, at 11:20, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> 
> James Clarke, le Sat 29 Aug 2015 11:15:29 +0100, a écrit :
>> @@ -1069,33 +1068,12 @@ kdstart(struct tty *tp)
>>            break;
>>        if ((tp->t_outq.c_cc <= 0) || (ch = getc(&tp->t_outq)) == -1)
>>            break;
>> -        c = ch;
>>        /*
>>         * Drop priority for long screen updates. ttstart() calls us at
>>         * spltty.
>>         */
>>        o_pri = splsoftclock();        /* block timeout */
>> -        if (c == (K_ESC)) {
> ...
>> -        }
>> +        kd_putc(ch);
> 
> I don't understand: shouldn't that be kd_putc_esc?
> 
> Samuel