bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Confusing definitions and declarations of mig_dealloc_reply_port()


From: Diego Nieto Cid
Subject: Re: Confusing definitions and declarations of mig_dealloc_reply_port()
Date: Wed, 4 Nov 2015 10:50:35 -0300

Hi

2015-11-04 6:30 GMT-03:00 Svante Signell <svante.signell@gmail.com>:
>
> Diego,
> Cc: bug-hurd.

Oh, I mistakenly hit 'Reply'. I hate when that happens :(

> On Tue, 2015-11-03 at 15:55 -0300, Diego Nieto Cid wrote:
>
> > I'd suggest to assert (port == arg || arg == MACH_PORT_NULL) just to
> > be sure users don't expect
> > other port to be deallocated, which would be a bug.
>
> See above.
>

Hmm, I should have written

  assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL)

AIUI any other values are bogus given how 'mig_get_reply_port' and 'mig_dealloc_reply_port' are meant to be paired.

May be someone more knowledgeable can shed some ligth to the issue.

> >
> > [*]...probably because of this :)
>
> Why not change mig, is it holy?

No. I just meant whoever wrote that code wasn't willing or didn't have the time to engage in such a task.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]