Re: PATCH: Hurd FTBFS with perl 5.22

[James Clarke]

On 4 Jan 2016, at 22:13, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote:
>> Obviously the !defined(@val) is
>> no longer allowed, and I don't know how to rewrite that condition.
> 
> Perhaps juste !@val?
> I have no idea, I don't know perl. But probably worth trying and
> investigating, and I believe you can do it.

It is indeed just !@val (this use of defined was deprecated in 5.6.1 and raised 
warnings since 5.16[1]). Here's the simplified patch (untested):

> Index: hurd-0.7/libdde-linux26/lib/src/kernel/timeconst.pl
> ===================================================================
> --- hurd-0.7.orig/libdde-linux26/lib/src/kernel/timeconst.pl
> +++ hurd-0.7/libdde-linux26/lib/src/kernel/timeconst.pl
> @@ -369,10 +369,10 @@ if ($hz eq '--can') {
>               die "Usage: $0 HZ\n";
>       }
> 
>       @val = @{$canned_values{$hz}};
> -     if (!defined(@val)) {
> +     if (!@val) {
>               @val = compute_values($hz);
>       }
>       output($hz, @val);
>  }
>  exit 0;


James

[1] 
https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod#defined-array-and-defined-hash-are-now-fatal-errors

signature.asc
Description: Message signed with OpenPGP using GPGMail