[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: [PATCH hurd 1/6] Add file record locking support: libfshelp_rlo
From: |
Svante Signell |
Subject: |
Re: RFC: [PATCH hurd 1/6] Add file record locking support: libfshelp_rlock.patch |
Date: |
Thu, 25 Feb 2016 10:16:59 +0100 |
On Mon, 2016-02-08 at 23:33 +0100, Samuel Thibault wrote:
> Svante Signell, on Mon 08 Feb 2016 12:51:42 +0100, wrote:
> > 1) Locks are inherited by fork, they should not. Test program: libfshelp-
> > tests/fork.c
>
> As I mentioned previously, this should be fine for now.
>
> > 2) The pid of a conflicting process locking a file is not returned.
>
> Similarly, we can make GETLK return ENOSYS in glibc for now, that should
> be fine for now, as long as we already introduce in the RPC API the
> token needed for:
>
> > Both problems will be solved by implementation of the
> > proc_user_identify/proc_server_identify RPCs with corresponding adjustments
> > to
> > the code in this patch.
I didn't really grok your reply here:
Do you really mean I should update the glibc patch to return ENOSYS for GETLK
and that we can implement proc_user_identify/proc_server_identify RPCs and fix
the remaining issues for file record locking later on?