bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix use of stringize in lexxer.l


From: Flavio Cruz
Subject: [PATCH] Fix use of stringize in lexxer.l
Date: Sun, 3 Apr 2016 16:12:16 +0200
User-agent: Mutt/1.5.24 (2015-08-30)

The fields instr and outstr should be set to a string and not to the
stringified number represented by the string. This improves the readability of
mig stubs code that creates mach_msg_type_t values for messages.

* lexxer.l: Inline stringize in TPRETURN and TRETURN.
---
 lexxer.l | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/lexxer.l b/lexxer.l
index bd7a718..9579522 100644
--- a/lexxer.l
+++ b/lexxer.l
@@ -53,8 +53,6 @@ FileName      ({QString}|{AString})
 /* We do not need the input function.  */
 #define YY_NO_INPUT
 
-#define        stringize(x)    #x
-
 #ifdef LDEBUG
 #define RETURN(sym)                                                    \
 {                                                                      \
@@ -68,14 +66,22 @@ FileName    ({QString}|{AString})
 #define        TPRETURN(intype, outtype, tsize)                                
\
 {                                                                      \
     yylval.symtype.innumber = (intype);                                        
\
-    yylval.symtype.instr = stringize(intype);                          \
+    yylval.symtype.instr = #intype;                                    \
     yylval.symtype.outnumber = (outtype);                              \
-    yylval.symtype.outstr = stringize(outtype);                                
\
+    yylval.symtype.outstr = #outtype;                                  \
     yylval.symtype.size = (tsize);                                     \
     RETURN(sySymbolicType);                                            \
 }
 
-#define        TRETURN(type, tsize)    TPRETURN(type,type,tsize)
+#define        TRETURN(type, tsize)                                            
\
+{                                                                      \
+    yylval.symtype.innumber = (type);                                  \
+    yylval.symtype.instr = #type;                                      \
+    yylval.symtype.outnumber = (type);                                 \
+    yylval.symtype.outstr = #type;                                     \
+    yylval.symtype.size = (tsize);                                     \
+    RETURN(sySymbolicType);                                            \
+}
 
 #define        FRETURN(val)                                                    
\
 {                                                                      \
-- 
2.7.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]