bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use uint32_t instead of unsigned32_t.


From: Flávio Cruz
Subject: Re: [PATCH] Use uint32_t instead of unsigned32_t.
Date: Tue, 5 Apr 2016 00:39:48 +0200



On 4 April 2016 at 20:19, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
Quoting Flavio Cruz (2016-03-15 10:48:48)
> * utils.c: Generate code using uint32_t.
> ---
>  utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils.c b/utils.c
> index 4c2a87b..ccde966 100644
> --- a/utils.c
> +++ b/utils.c
> @@ -77,7 +77,7 @@ WriteBogusDefines(FILE *file)
>
>      fprintf(file, "#define BAD_TYPECHECK(type, check) mig_unlikely (({\\\n");
>      fprintf(file,
> -           "  union { mach_msg_type_t t; unsigned32_t w; } _t, _c;\\\n");
> +           "  union { mach_msg_type_t t; uint32_t w; } _t, _c;\\\n");

This broke your test suite:

FAIL: case
==========

Generating stubs for case...
Compiling stubs for case...
case-server.c: In function ‘_Xfactorial’:
case-server.c:35:30: error: unknown type name ‘uint32_t’
union { mach_msg_type_t t; uint32_t w; } _t, _c;\
^
case-server.c:23:47: note: in definition of macro ‘mig_unlikely’
#define mig_unlikely(X) __builtin_expect (!! (X), 0)
^
case-server.c:93:6: note: in expansion of macro ‘BAD_TYPECHECK’
if (BAD_TYPECHECK(&In0P->nType, &nCheck))
^
ERROR: Could not compile stubs for case
FAIL case.defs (exit status: 1)

(likewise directions.defs)


Should work with the new patch. Thanks for the report.

Flavio
 
Justus

>      fprintf(file,
>             "  _t.t = *(type); _c.t = *(check);_t.w != _c.w; }))\n");
>  }
> --
> 2.6.4
>
>



--
Flávio Cruz / flaviocruz@gmail.com

reply via email to

[Prev in Thread] Current Thread [Next in Thread]