bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)


From: Samuel Thibault
Subject: Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)
Date: Tue, 30 Aug 2016 23:21:40 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Svante Signell, on Tue 30 Aug 2016 17:40:00 +0200, wrote:
> Attached is an updated patch returning also EINVAL if abs(delta) is too large.

Never mix changes, please.

> Whether the  adjtime()/RPC_host_adjust_time.c:___host_adjust_time() survives a
> delta being NULL remains to test.

Well, there is no need to test::)

*(time_value_t *) delta,

will just crash.

> According to the manpage the bug was:

Again, note that manpages are often talking about the Linux
implementation only :)

We should probably try to implement the delta==NULL feature, though.

Thanks for the patch,
Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]