Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)

[Samuel Thibault]

Svante Signell, on Tue 30 Aug 2016 23:38:19 +0200, wrote:
> On Tue, 2016-08-30 at 23:21 +0200, Samuel Thibault wrote:
> > Svante Signell, on Tue 30 Aug 2016 17:40:00 +0200, wrote:
> > > 
> > > Attached is an updated patch returning also EINVAL if abs(delta) is too
> > > large.
> > Never mix changes, please.
> > 
> > > 
> > > Whether the  adjtime()/RPC_host_adjust_time.c:___host_adjust_time() 
> > > survives
> > > a
> > > delta being NULL remains to test.
> > Well, there is no need to test::)
> > 
> > *(time_value_t *) delta,
> > 
> > will just crash.
> 
> How probable is this kind of (misuse) of this function?

? It's not misuse, it's even documented in the manual.

> Nevertheless, maybe we could use another dummy struct timespec (or the
> one already available)?

No. Please think about what values you would put in the dummy struct,
and what consequence they will have.

Samuel